Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data generation #175

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Use data generation #175

merged 5 commits into from
Jun 17, 2024

Conversation

haykam821
Copy link
Contributor

This pull request migrates data, including block tags, item tags, and (soon) advancements, to data generation. Note that ./gradlew runDatagen must now be ran before running a development environment client or server.

This pull request is marked as a draft as it is blocked by #172. Some advancements cannot currently be moved to data generation since their criteria are invalid.

@haykam821 haykam821 marked this pull request as ready for review June 9, 2024 20:05
Copy link
Member

@Gegy Gegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - but also missing the runDatagen task from the release pipeline :)

@haykam821 haykam821 requested a review from Gegy June 17, 2024 12:17
@Gegy Gegy merged commit 48a86ee into NucleoidMC:1.20.4 Jun 17, 2024
1 check passed
@haykam821 haykam821 deleted the data-generation branch June 17, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants